Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven Resolver: initialize Maven properly, especially the local repository #45794

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Maven Resolver: initialize Maven properly, especially the local repository #45794

merged 1 commit into from
Jan 23, 2025
+126 −85

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 22, 2025

The BootstrapMavenContext.newRepositorySystemSession() method is now a lot closer to DefaultRepositorySystemSessionFactory.newRepositorySession(), especially around how it initializes the LocalRepositoryManager. It is now done after setting up the config properties on the RepositorySystemSession, which has also been fixed (to include the properties of all active profiles, including those in settings.xml).

Furhter, this commit renames 2 files to match the name of the (non-public) class declared in them, and fixes self type emulation in BootstrapMavenContextConfig.

Fixes #44484

@Ladicek Ladicek requested a review from aloubyansky January 22, 2025 14:24
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jan 22, 2025
aloubyansky
aloubyansky approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Ladicek Thanks a lot!

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@Ladicek Ladicek force-pushed the maven-fix-split-local-repo branch from b5fe0f5 to 9e56392 Compare January 23, 2025 08:46
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@Ladicek
Maven Resolver: initialize Maven properly, especially the local repos…
d032483 
…itory

The `BootstrapMavenContext.newRepositorySystemSession()` method is now
a lot closer to `DefaultRepositorySystemSessionFactory.newRepositorySession()`,
especially around how it initializes the `LocalRepositoryManager`. It is now
done _after_ setting up the config properties on the `RepositorySystemSession`,
which has also been fixed (to include the properties of all active profiles,
including those in `settings.xml`).

Furhter, this commit renames 2 files to match the name of the (non-`public`)
class declared in them, and fixes self type emulation in `BootstrapMavenContextConfig`.
@Ladicek Ladicek force-pushed the maven-fix-split-local-repo branch from 9e56392 to d032483 Compare January 23, 2025 10:16
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 23, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d032483.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
	at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

@aloubyansky aloubyansky merged commit 9eb63b6 into quarkusio:main Jan 23, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/bugfix triage/backport triage/flaky-test
Projects
None yet
Milestone
3.19 - main
Development

Successfully merging this pull request may close these issues.

Quarkus Build with Maven Artefact Resolver Configuration Options
2 participants
@Ladicek @aloubyansky